[PATCH] drm/vblank: Use u32 consistently for vblank counters

Thierry Reding thierry.reding at gmail.com
Fri Aug 7 04:56:37 PDT 2015


On Fri, Aug 07, 2015 at 12:31:17PM +0200, Daniel Vetter wrote:
> In
> 
> commit 99264a61dfcda41d86d0960cf2d4c0fc2758a773
> Author: Daniel Vetter <daniel.vetter at ffwll.ch>
> Date:   Wed Apr 15 19:34:43 2015 +0200
> 
>     drm/vblank: Fixup and document timestamp update/read barriers
> 
> I've switched vblank->count from atomic_t to unsigned long and
> accidentally created an integer comparison bug in
> drm_vblank_count_and_time since vblanke->count might overflow the u32
> local copy and hence the retry loop never succeed.
> 
> Fix this by consistently using u32.
> 
> Cc: Michel Dänzer <michel at daenzer.net>
> Reported-by: Michel Dänzer <michel at daenzer.net>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  drivers/gpu/drm/drm_irq.c | 2 +-
>  include/drm/drmP.h        | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Thierry Reding <treding at nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150807/28bdfee4/attachment.sig>


More information about the dri-devel mailing list