[PATCH] drm/amdgpu: partially revert "drm/amdgpu: fix VM_CONTEXT*_PAGE_TABLE_END_ADDR" v2

Alex Deucher alexdeucher at gmail.com
Fri Dec 4 10:07:27 PST 2015


On Thu, Dec 3, 2015 at 2:54 PM, Christian König <deathsimple at vodafone.de> wrote:
> From: Christian König <christian.koenig at amd.com>
>
> The gtt_end is already inclusive, we don't need to subtract one here.
>
> v2 (chk): keep the fix for the VM code, cause here it really applies.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> Signed-off-by: Anatoli Antonovitch <anatoli.antonovitch at amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> Cc: stable at vger.kernel.org

Applied.  thanks!

> ---
>  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 +-
>  drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> index 7427d8c..ed8abb5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> @@ -513,7 +513,7 @@ static int gmc_v7_0_gart_enable(struct amdgpu_device *adev)
>         WREG32(mmVM_L2_CNTL3, tmp);
>         /* setup context0 */
>         WREG32(mmVM_CONTEXT0_PAGE_TABLE_START_ADDR, adev->mc.gtt_start >> 12);
> -       WREG32(mmVM_CONTEXT0_PAGE_TABLE_END_ADDR, (adev->mc.gtt_end >> 12) - 1);
> +       WREG32(mmVM_CONTEXT0_PAGE_TABLE_END_ADDR, adev->mc.gtt_end >> 12);
>         WREG32(mmVM_CONTEXT0_PAGE_TABLE_BASE_ADDR, adev->gart.table_addr >> 12);
>         WREG32(mmVM_CONTEXT0_PROTECTION_FAULT_DEFAULT_ADDR,
>                         (u32)(adev->dummy_page.addr >> 12));
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> index cb0e50e..d390284 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> @@ -657,7 +657,7 @@ static int gmc_v8_0_gart_enable(struct amdgpu_device *adev)
>         WREG32(mmVM_L2_CNTL4, tmp);
>         /* setup context0 */
>         WREG32(mmVM_CONTEXT0_PAGE_TABLE_START_ADDR, adev->mc.gtt_start >> 12);
> -       WREG32(mmVM_CONTEXT0_PAGE_TABLE_END_ADDR, (adev->mc.gtt_end >> 12) - 1);
> +       WREG32(mmVM_CONTEXT0_PAGE_TABLE_END_ADDR, adev->mc.gtt_end >> 12);
>         WREG32(mmVM_CONTEXT0_PAGE_TABLE_BASE_ADDR, adev->gart.table_addr >> 12);
>         WREG32(mmVM_CONTEXT0_PROTECTION_FAULT_DEFAULT_ADDR,
>                         (u32)(adev->dummy_page.addr >> 12));
> --
> 2.5.0
>


More information about the dri-devel mailing list