[PATCH 2/7] drm/omap: remove extra drm_gem_free_mmap_offset() call

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Dec 13 12:33:21 PST 2015


Hi Tomi,

Thank you for the patch.

On Wednesday 09 December 2015 17:38:06 Tomi Valkeinen wrote:
> drm_gem_object_release() calls drm_gem_free_mmap_offset(), so there's no
> need to call drm_gem_free_mmap_offset() in omap_gem_free_object().
> 
> This patch removes the extra drm_gem_free_mmap_offset() call, and should
> have no side effects.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

See "[PATCH 11/15] drm: omapdrm: gem: Don't free mmap offset twice" from my 
dmabuf import series ;-)

> ---
>  drivers/gpu/drm/omapdrm/omap_gem.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c
> b/drivers/gpu/drm/omapdrm/omap_gem.c index 7ed08fdc4c42..f9ddbf53345c
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -1282,8 +1282,6 @@ void omap_gem_free_object(struct drm_gem_object *obj)
>  	list_del(&omap_obj->mm_list);
>  	spin_unlock(&priv->list_lock);
> 
> -	drm_gem_free_mmap_offset(obj);
> -
>  	/* this means the object is still pinned.. which really should
>  	 * not happen.  I think..
>  	 */

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list