[libdrm][PATCH 2/2] Fix gcc -Wextra warnings

[Emil Velikov]

On 10 February 2015 at 00:02, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> On Mon, 2015-02-09 at 23:32 +0000, Emil Velikov wrote:
>> On 9 February 2015 at 21:39, Jan Vesely <jan.vesely at rutgers.edu> wrote:
>> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
>> Nice one Jan. I've sent similar fixes for drmOpenDevice and
>> drmGetStats a few days ago.
>>
>> Considering you drop the last hunk that Ian spotted both patches are
>> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>
> Thanks, I sent v2 of that patch few minutes ago.
>
> I think your 4/6 and 5/6 overlap with this one. Should I go ahead or do
> you plan to push yours?
>
I would go with your series - it handles more cases, plus already has
move reviews :-P
If you feel like looking through some of my series that would be appreciated.

>>
>> The strange part is that the normal Linux build does not show even a
>> single warning, despite the -Wextra and -Wsign-compare flags from
>> configure.ac. Perhaps my gcc does not like libdrm for some reason :P
>
> I think I just used CFLAGS= during configure, and it worked
> jan
>
Yes the issue was that we're not using WARN_CFLAGS in every Makefile in libdrm.
Namely the top one and most of the tests.

-Emil