[PATCH 3/3] drm/amdkfd: Handle case of invalid queue type

[Oded Gabbay]

On 01/22/2015 12:28 PM, Zhou, Jammy wrote:
> Patches are Reviewed-by: Jammy Zhou <Jammy.Zhou at amd.com>
>
> Regards,
> Jammy
>
Thanks!
	Oded
> -----Original Message-----
> From: dri-devel [mailto:dri-devel-bounces at lists.freedesktop.org] On Behalf Of Gabbay, Oded
> Sent: Thursday, January 22, 2015 5:42 PM
> To: dri-devel at lists.freedesktop.org
> Subject: [PATCH 3/3] drm/amdkfd: Handle case of invalid queue type
>
> This patch handles a case where amdkfd tries to destroy a queue but the queue type is invalid.
> This case occurs in non-HWS path.
>
> Signed-off-by: Oded Gabbay <oded.gabbay at amd.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 85387c8..99e2dbb 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -301,6 +301,11 @@ static int destroy_queue_nocpsch(struct device_queue_manager *dqm,
>   		}
>   		dqm->sdma_queue_count--;
>   		deallocate_sdma_queue(dqm, q->sdma_id);
> +	} else {
> +		pr_debug("q->properties.type is invalid (%d)\n",
> +				q->properties.type);
> +		retval = -EINVAL;
> +		goto out;
>   	}
>
>   	retval = mqd->destroy_mqd(mqd, q->mqd,
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>