[PATCH] drm/nouveau/bar: fix simple_return.cocci warnings

kbuild test robot fengguang.wu at intel.com
Sat Jan 24 22:24:49 PST 2015


drivers/gpu/drm/nouveau/core/subdev/bar/base.c:132:5-8: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci

Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 base.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
@@ -129,10 +129,7 @@ nouveau_bar_create_(struct nouveau_objec
 	ret = nouveau_subdev_create_(parent, engine, oclass, 0, "BARCTL",
 				     "bar", length, pobject);
 	bar = *pobject;
-	if (ret)
-		return ret;
-
-	return 0;
+	return ret;
 }
 
 void


More information about the dri-devel mailing list