[PATCH] drm: sti: fix sub-components bind

Xinwei Kong kong.kongxinwei at hisilicon.com
Thu Jul 16 02:13:09 PDT 2015


hi ben:

your patch is ok, i don't know your hardware how to use. In this first
code why use that style dts? If you detail research our patch, you will
find that it can compatiable your fixing dts.

If you don't approve our patch better, I will be glad to see you to slove
this bug

Thank you
Xinwei

On 2015/7/15 21:34, Thierry Reding wrote:
> On Wed, Jul 15, 2015 at 03:21:46PM +0200, Benjamin Gaignard wrote:
>> Fix misunderstanding in how use component framework.
>> drm_platform_init() is now call only when all the
>> sub-components are register themselves instead of the
>> previous two stages mechanism.
>>
>> Update devicetree and bindings documentation according
>> to this new behavior.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard at linaro.org>
>> ---
>>  .../devicetree/bindings/gpu/st,stih4xx.txt         |  7 +-
>>  arch/arm/boot/dts/stih407.dtsi                     | 82 +++++++++++-----------
>>  arch/arm/boot/dts/stih410.dtsi                     | 82 +++++++++++-----------
>>  drivers/gpu/drm/sti/sti_drm_drv.c                  | 45 ++----------
>>  drivers/gpu/drm/sti/sti_hdmi.c                     | 25 ++++---
>>  drivers/gpu/drm/sti/sti_tvout.c                    | 46 ++----------
>>  6 files changed, 105 insertions(+), 182 deletions(-)
> 
> Isn't this going to break DT ABI? How are you going to ensure backwards-
> compatibility with old DTBs?
> 
> Thierry
> 



More information about the dri-devel mailing list