[PATCH v3 09/15] drm: tilcdc: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp()

[Daniel Vetter]

On Fri, Jun 10, 2016 at 04:25:47PM +0300, Ville Syrjälä wrote:
> On Fri, Jun 10, 2016 at 04:16:06PM +0300, Jyri Sarha wrote:
> > On 06/10/16 16:08, Tomi Valkeinen wrote:
> > > On 10/06/16 15:48, Tomi Valkeinen wrote:
> > >> On 10/06/16 15:29, Ville Syrjälä wrote:
> > >>
> > >>>> The HW does not support any kind of blending to black
> > >>>> or to anything else.
> > >>>
> > >>> Right. Then formats with alpha shouldn't be advertized.
> > >>
> > >> I don't think tilcdc does. It comes from the DRM core. With universal
> > >> planes this will be fixed as the driver can define the formats.
> > > 
> > > Actually, Jyri told that modetest only reports "RG16 RG24 XR24", which
> > > is correct. I think it did contain AR24 at some point, but maybe I
> > > remember wrong. I have no idea where those come from, though, as they
> > > are not defined in tilcdc (at least not in that form)...
> > > 
> > 
> > That was on top of my atomic modeset patches. The current mainline
> > version reports "XR24 AR24".
> 
> Hmm. Oh, I guess we should kill ARGB8888 from safe_modeset_formats[]
> and drm_mode_legacy_fb_format(). That should do it I think.

Just convert over to universal planes already, because without those
userspace has no way to figure out what works (except by trying).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch