[PATCH 5/7] drm/stm: dsi: Remove unnecessary platform_get_resource() error check

Philippe CORNU philippe.cornu at st.com
Tue Dec 19 14:14:48 UTC 2017


Dear Fabio,

On 12/18/2017 02:02 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
> 
> devm_ioremap_resource() already checks if the resource is NULL, so
> remove the unnecessary platform_get_resource() error check.
> 
> Cc: Philippe Cornu <philippe.cornu at st.com>
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
>   drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 82dcb20..fd02506 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -290,11 +290,6 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		DRM_ERROR("Unable to get resource\n");
> -		return -ENODEV;
> -	}
> -

Many thanks for this cleanup.

Acked-by: Philippe Cornu <philippe.cornu at st.com>

Philippe :-)

>   	dsi->base = devm_ioremap_resource(dev, res);
>   	if (IS_ERR(dsi->base)) {
>   		DRM_ERROR("Unable to get dsi registers\n");
> 


More information about the dri-devel mailing list