[PATCH v2] gpu: anx7808: fix a missing check in anx78xx_poweron

Kangjie Lu kjlu at umn.edu
Tue Dec 25 05:18:17 UTC 2018


Please ignore this email. I've sent another one.

On Mon, Dec 24, 2018 at 11:02 PM Kangjie Lu <kjlu at umn.edu> wrote:

> Both anx78xx_set_bits() and anx78xx_clear_bits() in the poweron process
> may fail. The fix inserts checks for their return values.
>
> Signed-off-by: Kangjie Lu <kjlu at umn.edu>
> ---
>  drivers/gpu/drm/bridge/analogix-anx78xx.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c
> b/drivers/gpu/drm/bridge/analogix-anx78xx.c
> index 3b0fe2b188db..4f35aced65a0 100644
> --- a/drivers/gpu/drm/bridge/analogix-anx78xx.c
> +++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c
> @@ -646,6 +646,7 @@ static void anx78xx_poweron(struct anx78xx *anx78xx)
>                                 err);
>                 return;
>         }
> +
>         err = anx78xx_clear_bits(anx78xx->map[I2C_IDX_TX_P2],
>                         SP_POWERDOWN_CTRL_REG,
>                         SP_REGISTER_PD | SP_TOTAL_PD);
> --
> 2.17.2 (Apple Git-113)
>
>

-- 
Kangjie Lu
Assistant Professor
Department of Computer Science and Engineering
University of Minnesota
Personal homepage <https://www-users.cs.umn.edu/~kjlu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20181224/956b3721/attachment-0001.html>


More information about the dri-devel mailing list