[PATCH 1/5] drm/vblank: Fix return type for drm_vblank_count()

Keith Packard keithp at keithp.com
Wed Jan 31 06:42:13 UTC 2018


Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com> writes:

> drm_vblank_count() has a u32 type returning what is a 64-bit vblank
> count.

It looks like a general review of the 64-bit widening patch is needed.

 * drm_crtc_accurate_vblank_count has a 32-bit return, and uses a 32-bit temporary
 * drm_wait_one_vblank uses a 32-bit temporary.

I looked at every 'u32' in drm_vblank.c; it would be good to have more
eyes check this.

Thanks for finding the first one.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180130/cf256de3/attachment-0001.sig>


More information about the dri-devel mailing list