[PATCH v3] backlight: pwm_bl: switch to using "atomic" PWM API

Heiko Stuebner heiko at sntech.de
Fri Sep 28 13:21:47 UTC 2018


Hi Lee,

Am Montag, 10. September 2018, 16:49:24 CEST schrieb Lee Jones:
> On Tue, 14 Aug 2018, Enric Balletbo i Serra wrote:
> 
> > The "atomic" API allows us to configure PWM period and duty_cycle and
> > enable it in one call.
> > 
> > The patch also moves the pwm_init_state just before any use of the
> > pwm_state struct, this fixes a potential bug where pwm_get_state
> > can be called before pwm_init_state.
> > 
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo at collabora.com>
> > ---
> > 
> > Changes in v3:
> > - Get rid of duty_cycle variable from pwm_backlight_update_status.
> > - Get rid of pb->enabled and use only the status.enabled variable.
> > - Make power_on match power_off.
> > - Do not share status between ...update_status and ...power_on
> > 
> > Changes in v2:
> > - Do not force the PWM be off in the first call to pwm_apply_state.
> > - Delayed applying the state until we know what the period is.
> > - Removed pb->period as after the conversion is not needed.
> > 
> >  drivers/video/backlight/pwm_bl.c | 81 +++++++++++++++++---------------
> >  1 file changed, 42 insertions(+), 39 deletions(-)
> 
> Applied, thanks.

did this miss some push or so, because looking at [0], I don't see
any new patches for a while now?

Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git/




More information about the dri-devel mailing list