[RFC][PATCH 2/5] libdrm: amdgpu: Initialize unions with memset rather than "= {0}"

Christian König ckoenig.leichtzumerken at gmail.com
Tue Apr 23 12:51:53 UTC 2019


Am 22.04.19 um 20:35 schrieb John Stultz:
> On Mon, Apr 22, 2019 at 7:59 AM Alex Deucher <alexdeucher at gmail.com> wrote:
>> On Sat, Apr 20, 2019 at 12:25 AM John Stultz <john.stultz at linaro.org> wrote:
>>> Clang complains when initializing unions using "= {0}"
>>> so instead use memset.
>>>
>>> Cc: Emil Velikov <emil.velikov at collabora.com>
>>> Cc: Sean Paul <seanpaul at chromium.org>
>>> Cc: Alistair Strachan <astrachan at google.com>
>>> Cc: Marissa Wall <marissaw at google.com>
>>> Signed-off-by: John Stultz <john.stultz at linaro.org>
>> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> Thanks for the review!

Reviewed-by: Christian König <christian.koenig at amd.com>

We should probably do the same thing for the kernel as well.

>
>> Do you have commit rights?

We will take care of getting this committed then.

Christian.

> I don't.
>
> thanks again,
> -john
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



More information about the dri-devel mailing list