[PATCH v2 5/5] drm/vram: Don't export driver callback functions for PRIME

[Gerd Hoffmann]

  Hi,

> +static void drm_gem_vram_object_free(struct drm_gem_object *gem)
> +{
> +	struct drm_gem_vram_object *gbo = drm_gem_vram_of_gem(gem);
> +
> +	drm_gem_vram_put(gbo);
> +}

Hmm, seems git diff didn't figure it's the same func just renamed
(likewise pin/unpin/vmap/vunmap).  Maybe "git diff --minimal" gives
better results here.  Placing the object_funcs struct (patch 1) at the
end of the file might help too.

> -/**
> - * drm_gem_vram_driver_gem_free_object_unlocked() - \
> -	Implements &struct drm_driver.gem_free_object_unlocked
> - * @gem:	GEM object. Refers to &struct drm_gem_vram_object.gem
> - */

I think we should keep the documentation ...

> -EXPORT_SYMBOL(drm_gem_vram_driver_gem_free_object_unlocked);

And the EXPORT_SYMBOL too.

Drivers might want roll their own version of drm_gem_object_funcs,
with some of the functions replaced by driver-specific versions in
case they have some extra work to do.

cheers,
  Gerd