[PATCH v2 11/13] drm/modes: parse_cmdline: Explicitly memset the passed in drm_cmdline_mode struct

[Maxime Ripard]

On Mon, Nov 18, 2019 at 01:33:55PM +0100, Hans de Goede wrote:
> Hi,
>
> On 18-11-2019 13:28, Maxime Ripard wrote:
> > On Wed, Nov 13, 2019 at 05:44:32PM +0100, Hans de Goede wrote:
> > > Instead of only setting mode->specified on false on an early exit and
> > > leaving e.g. mode->bpp_specified and mode->refresh_specified as is,
> > > lets be consistent and just zero out the entire passed in struct at
> > > the top of drm_mode_parse_command_line_for_connector()
> > >
> > > Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> > > ---
> > >   drivers/gpu/drm/drm_modes.c | 5 ++---
> > >   1 file changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> > > index beb764efe6b3..1fee4a71eff7 100644
> > > --- a/drivers/gpu/drm/drm_modes.c
> > > +++ b/drivers/gpu/drm/drm_modes.c
> > > @@ -1745,12 +1745,11 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option,
> > >   	char *bpp_end_ptr = NULL, *refresh_end_ptr = NULL;
> > >   	int i, len, ret;
> > >
> > > +	memset(mode, 0, sizeof(*mode));
> > >   	mode->panel_orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
> >
> > The reported error by kbuild rings a bell. I think I tried to do this,
> > saw that error, and then forgot about it.
>
> kbuild(bot) error ? I did not see any messages about that for this patch,
> nor do I see any mails about this in the archives?

It was sent today at 8:28 UTC, subject "[drm/modes] 1ea4d22f11:
BUG:kernel_NULL_pointer_dereference,address". I'll bounce it to you,
but you were among the recipients, maybe it ended up in your spams?

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20191118/82d9cbfd/attachment.sig>