[RFCv1 32/42] drm/omap: dsi: convert to drm_panel

[H. Nikolaus Schaller]

> Am 18.11.2019 um 15:45 schrieb Sebastian Reichel <sebastian.reichel at collabora.com>:
> 
> Hi,
> 
> On Sun, Nov 17, 2019 at 08:23:05PM +0100, H. Nikolaus Schaller wrote:
>>> [...]
>> 
>>> +	drm_panel_init(&ddata->panel, dev, &dsicm_panel_funcs,
>>> +		       DRM_MODE_CONNECTOR_DSI);
>>> +
>> 
>> This leads to
>> 
>> drivers/gpu/drm/panel/panel-dsi-cm.c: In function 'dsicm_probe':
>> drivers/gpu/drm/panel/panel-dsi-cm.c:552:2: error: too many arguments to function 'drm_panel_init'
>>  drm_panel_init(&ddata->panel, dev, &dsicm_panel_funcs,
>>  ^
>> In file included from drivers/gpu/drm/panel/panel-dsi-cm.c:22:0:
>> ./include/drm/drm_panel.h:150:6: note: declared here
>> void drm_panel_init(struct drm_panel *panel);
>>      ^
>> 
>> (when applied to v5.4-rc7)
> 
> The patchset is based on drm-next from
> https://anongit.freedesktop.org/git/drm/drm.git
> 
> For v5.4-rc7 it needs to look like this:
> 
> +	drm_panel_init(&ddata->panel);
> +	ddata->panel.dev = dev;
> +	ddata->panel.funcs = &dsicm_panel_funcs;

Ah, ok. The issue with changed parameters seems
to already be fixed by two patches in linux-next
and therefore soon in v5.5-rc1.

> 
>>> [...] 
>> 
>> Otherwise the patches compile fine and my work-in progress
>> DSI panel driver is probing, but not initializing.
> 
> Ok, I tried not to break video mode support, but I do not have any
> hardware. Make sure to set the MIPI_DSI_MODE_VIDEO flag in the panel
> driver.

Indeed, this may be missing (can't look into the code at the moment)...
Or I did something wrong when refactoring the driver.
We will find out.

BR and thanks for the great work,
Nikolaus