[PATCH v3 11/13] drm/modes: parse_cmdline: Explicitly memset the passed in drm_cmdline_mode struct

Maxime Ripard maxime at cerno.tech
Mon Nov 18 16:56:39 UTC 2019


On Mon, Nov 18, 2019 at 04:51:32PM +0100, Hans de Goede wrote:
> Instead of only setting mode->specified on false on an early exit and
> leaving e.g. mode->bpp_specified and mode->refresh_specified as is,
> lets be consistent and just zero out the entire passed in struct at
> the top of drm_mode_parse_command_line_for_connector()
>
> Changes in v3:
> -Drop "mode->specified = false;" line instead of the "return false;" (oops)
>  This crasher was reported-by: kernel test robot <lkp at intel.com>
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Acked-by: Maxime Ripard <mripard at kernel.org>

Thanks!
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20191118/e32a349f/attachment-0001.sig>


More information about the dri-devel mailing list