[PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

Maxime Ripard mripard at kernel.org
Wed Sep 18 14:17:34 UTC 2019


Hi,

On Sun, Sep 15, 2019 at 12:03:37AM +0200, megous at megous.com wrote:
> From: Ondrej Jirman <megous at megous.com>
>
> There are various issues that this re-work of sun8i_[uv]i_layer_enable
> function fixes:
>
> - Make sure that we re-initialize zpos on reset
> - Minimize register updates by doing them only when state changes
> - Fix issue where DE pipe might get disabled even if it is no longer
>   used by the layer that's currently calling sun8i_ui_layer_enable
> - .atomic_disable callback is not really needed because .atomic_update
>   can do the disable too, so drop the duplicate code
>
> Signed-off-by: Ondrej Jirman <megous at megous.com>

It looks like these fixes should be in separate patches. Is there any
reason it's not the case?

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190918/0130d774/attachment.sig>


More information about the dri-devel mailing list