[PATCH 2/2] drm/vmwgfx: Remove a few unused functions

Emil Velikov emil.l.velikov at gmail.com
Fri Feb 28 11:42:46 UTC 2020


Hi Sebastian,

On Mon, 24 Feb 2020 at 16:55, Sebastian Andrzej Siewior
<bigeasy at linutronix.de> wrote:
>
> I noticed that there is a prototype for vmw_fifo_ping_host_locked() but
> no function. Then I looked further and noticed more functions which are
> not used anymore or functions protoypes which remained after the
> function was removed.
>
> Remove unused function (prototypes).
>
Seems like the last user was removed in 2015 with commit a278724aa23c
("drm/vmwgfx: Implement fbdev on kms v2").

With this patch, the section of "VGA registers" in struct vmw_private
becomes dead code.
IMHO it would make sense to also remove those with this patch.

HTH
Emil


More information about the dri-devel mailing list