[PATCH v4 2/2] drm/vc4: kms: Don't disable the muxing of an active CRTC

Maxime Ripard maxime at cerno.tech
Mon Nov 23 16:59:44 UTC 2020


On Mon, Nov 23, 2020 at 08:50:49AM +0100, Thomas Zimmermann wrote:
> 
> 
> Am 20.11.20 um 15:42 schrieb Maxime Ripard:
> > The current HVS muxing code will consider the CRTCs in a given state to
> > setup their muxing in the HVS, and disable the other CRTCs muxes.
> > 
> > However, it's valid to only update a single CRTC with a state, and in this
> > situation we would mux out a CRTC that was enabled but left untouched by
> > the new state.
> > 
> > Fix this by setting a flag on the CRTC state when the muxing has been
> > changed, and only change the muxing configuration when that flag is there.
> > 
> > Fixes: 87ebcd42fb7b ("drm/vc4: crtc: Assign output to channel automatically")
> > Reviewed-by: Hoegeun Kwon <hoegeun.kwon at samsung.com>
> > Tested-by: Hoegeun Kwon <hoegeun.kwon at samsung.com>
> > Signed-off-by: Maxime Ripard <maxime at cerno.tech>
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>

Applied both, thanks!
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201123/41d00936/attachment-0001.sig>


More information about the dri-devel mailing list