[PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

Sam Ravnborg sam at ravnborg.org
Thu Sep 10 18:33:43 UTC 2020


Hi Daniel.

> > +	}
> > +
> > +	/* Initialize MIPI DSI */
> > +	ret = kmb_dsi_init(drm, adv_bridge);
> 
> Split up isn't correct here, this won't compile since the dsi code isn't
> in this patch yet. So you need to have this ordered the other way round.

I have explicit asked for a simple file split as done here
and told Anitha this was fine.

As the kbuild/kconfig bits are the last patch then no build breakage.
The file based split was IMO fine to ease review.

If this is not OK then blame me :-)

	Sam


More information about the dri-devel mailing list