[PATCH] drm/bridge: Ignore -EPROBE_DEFER when bridge attach fails

Sam Ravnborg sam at ravnborg.org
Thu Oct 14 19:35:20 UTC 2021


Hi Guido,

> > >  
> > > +	if (ret != -EPROBE_DEFER) {
> > >  #ifdef CONFIG_OF
> > > -	DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n",
> > > -		  bridge->of_node, encoder->name, ret);
> > > +		DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n",
> > > +			  bridge->of_node, encoder->name, ret);
> > 
> > It would be better to use drm_probe_err().
> 
> That's what i thought initially but since the rest here uses DRM_*
> logging i stuck with it. Happy to change that though.

If we continue to use the deprecated DRM_ logging functions then we will
never get rid of them. And then I like the simplicity of
drm_probe_err().

In the end it is up to you.

	Sam


More information about the dri-devel mailing list