[PATCH] drm/ttm: fix memleak in ttm_transfered_destroy

Christian König ckoenig.leichtzumerken at gmail.com
Thu Oct 21 09:05:54 UTC 2021



Am 20.10.21 um 19:47 schrieb Christian König:
> Am 20.10.21 um 19:43 schrieb Alex Deucher:
>> On Wed, Oct 20, 2021 at 1:32 PM Christian König
>> <ckoenig.leichtzumerken at gmail.com> wrote:
>>> We need to cleanup the fences for ghost objects as well.
>>>
>>> Signed-off-by: Christian König <christian.koenig at amd.com>
>>> CC: <stable at vger.kernel.org>
>> Does this fix this bug?
>> https://bugzilla.kernel.org/show_bug.cgi?id=214029
>
> Yeah, I was already adding that patch to the bug report as potential fix.

Ok that indeed fixes the issues we were seeing.

Can I get an acked or reviewed-by so that I can push this to 
drm-misc-fixes ASAP?

Thanks,
Christian.

>
> Christian.
>
>>
>> Alex
>>
>>> ---
>>>   drivers/gpu/drm/ttm/ttm_bo_util.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c 
>>> b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> index 82af095f6b81..f37a8c53b35f 100644
>>> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
>>> @@ -190,6 +190,7 @@ static void ttm_transfered_destroy(struct 
>>> ttm_buffer_object *bo)
>>>          struct ttm_transfer_obj *fbo;
>>>
>>>          fbo = container_of(bo, struct ttm_transfer_obj, base);
>>> +       dma_resv_fini(&fbo->base.base._resv);
>>>          ttm_bo_put(fbo->bo);
>>>          kfree(fbo);
>>>   }
>>> -- 
>>> 2.25.1
>>>
>



More information about the dri-devel mailing list