[PATCH v10 2/2] drm: exynos: dsi: Properly name HSA/HBP/HFP/HSE bits

Frieder Schrempf frieder.schrempf at kontron.de
Wed Dec 14 09:02:24 UTC 2022


On 12.12.22 15:57, Jagan Teki wrote:
> HSA/HBP/HFP/HSE mode bits in Processor Reference Manuals specify
> a naming conversion as 'disable mode bit' due to its bit definition,
> 0 = Enable and 1 = Disable.
> 
> For HSE bit, the i.MX 8M Mini/Nano/Plus Applications Processor
> Reference Manual named this bit as 'HseDisableMode' but the bit
> definition is quite opposite like
> 0 = Disables transfer
> 1 = Enables transfer
> which clearly states that HSE is not a disable bit.
> 
> HSE is named as per the manual even though it is not a disable
> bit however the driver logic for handling HSE is based on the
> MIPI_DSI_MODE_VIDEO_HSE flag itself.
> 
> Cc: Nicolas Boichat <drinkcat at chromium.org>
> Reviewed-by: Marek Vasut <marex at denx.de>
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>

Reviewed-by: Frieder Schrempf <frieder.schrempf at kontron.de>


More information about the dri-devel mailing list