[PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

Maxime Ripard maxime at cerno.tech
Thu Feb 3 15:06:05 UTC 2022


Hi Sam,

On Wed, Feb 02, 2022 at 06:14:16PM +0100, Sam Ravnborg wrote:
> Hi Noralf,
> 
> > > 
> > > Parts of it is ergonomics I guess. We're used to having all those
> > > properties either in the DT or the driver, but here we introduce a new
> > > way that isn't done anywhere else.
> > > 
> > > And I don't see any real downside to putting it in the DT? It's going to
> > > be in an overlay, under the user's control anyway, right?
> > > 
> > 
> > Ok, I'll spin a new version using DT properties.
> 
> I like this better than anything else as we then have everything in
> a single place when we add a new panel and more.
> I just recall some resistance to add such HW specific setup - but the
> usecase here is kinda special.

The main issue was to put the initialisation sequence in the device
tree. We solved that with by using a firmware instead. Given that the
timings, size and so on are already used by multiple, widely used,
panels, it should work just fine

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220203/43addfaf/attachment-0001.sig>


More information about the dri-devel mailing list