[PATCH 0/5] spi: make remove callback a void function

Mark Brown broonie at kernel.org
Wed Feb 9 14:34:08 UTC 2022


On Sun, 23 Jan 2022 18:51:56 +0100, Uwe Kleine-König wrote:
> this series goal is to change the spi remove callback's return value to void.
> After numerous patches nearly all drivers already return 0 unconditionally.
> The four first patches in this series convert the remaining three drivers to
> return 0, the final patch changes the remove prototype and converts all
> implementers.
> 
> The driver core doesn't support error handling on remove, the spi core issues
> only a very generic warning when a remove callback returns an error. If there
> is really the need for a function call that can fail, the driver can issue a
> more helpful error message. I didn't find a single driver where returning
> an error code and error handling in the spi core would have been helpful.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/5] staging: fbtft: Fix error path in fbtft_driver_module_init()
      commit: 7d8e4c98d13b6b54655140d6b6a6a17fbc9b32f1
[2/5] staging: fbtft: Deduplicate driver registration macros
      commit: c222ea5d2f3361458672d1f52c78970aa021cb61
[3/5] tpm: st33zp24: Make st33zp24_remove() a void function
      commit: 316f569df766df9a49c36c052ec6afaf19cb6933
[4/5] platform/chrome: cros_ec: Make cros_ec_unregister() return void
      commit: afb0a80e63d67e957b5d0eb4ade301aff6e13c8c
[5/5] spi: make remove callback a void function
      commit: 2cbfa2128662c6b841f68cd2fe54df199457e38a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


More information about the dri-devel mailing list