[PATCH V2] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check()

Marek Vasut marex at denx.de
Mon Feb 28 01:04:35 UTC 2022


On 2/21/22 13:31, Boris Brezillon wrote:
> On Mon, 21 Feb 2022 12:56:43 +0100
> Max Krummenacher <max.oss.09 at gmail.com> wrote:
> 
>> Am Montag, den 21.02.2022, 09:29 +0100 schrieb Boris Brezillon:
>>> Hello Christoph,
>>>
>>> On Sat, 19 Feb 2022 09:28:44 +0000
>>> Christoph Niedermaier <cniedermaier at dh-electronics.com> wrote:
>>>    
>>>> From: Max Krummenacher [mailto:max.oss.09 at gmail.com]
>>>> Sent: Wednesday, February 9, 2022 10:38 AM
>>>>>> If display timings were read from the devicetree using
>>>>>> of_get_display_timing() and pixelclk-active is defined
>>>>>> there, the flag DISPLAY_FLAGS_SYNC_POSEDGE/NEGEDGE is
>>>>>> automatically generated. Through the function
>>>>>> drm_bus_flags_from_videomode() e.g. called in the
>>>>>> panel-simple driver this flag got into the bus flags,
>>>>>> but then in imx_pd_bridge_atomic_check() the bus flag
>>>>>> check failed and will not initialize the display. The
>>>>>> original commit fe141cedc433 does not explain why this

Can you please update the commit message to fix the following warning:

Please use git commit description style 'commit <12+ chars of sha1> 
("<title line>")' - ie: 'commit fe141cedc433 ("drm/imx: pd: Use bus 
format/flags provided by the bridge when available")'

Also, collect the AB from Boris and TB from Max.

I can also fix it up for you while applying if that's OK with you.

[...]

> Acked-by: Boris Brezillon <boris.brezillon at collabora.com>

[...]


More information about the dri-devel mailing list