[Linaro-mm-sig] Re: [PATCH] drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

Greg KH gregkh at linuxfoundation.org
Thu Jun 16 08:43:43 UTC 2022


On Wed, Jun 15, 2022 at 10:30:47PM +0200, Daniel Vetter wrote:
> On Wed, 15 Jun 2022 at 22:23, Dave Airlie <airlied at gmail.com> wrote:
> >
> > On Wed, 15 Jun 2022 at 20:53, Greg KH <gregkh at linuxfoundation.org> wrote:
> > >
> > > On Wed, Jun 15, 2022 at 06:48:33PM +0800, heliang wrote:
> > > > In tegra_uart_init(), of_find_matching_node() will return a node
> > > > pointer with refcount incremented. We should use of_node_put()
> > > > when it is not used anymore.
> > > >
> > > > Signed-off-by: heliang <windhl at 126.com>
> > >
> > > We need a real name please, one you sign documents with.
> >
> > How do we enforce that? What if Wong, Adele or Beyonce submit a patch?
> >
> > What happens if that patch gets reposted, with S-o-b: He Liang
> > <windhl at 126.com> or Hel Iang, Heli Ang? Do you know any of those are
> > real names? What happens if they post a real name in
> > Mandarin/Thai/Cyrillic, can you validate it?
> >
> > Really we require you have an identity attached to an email. If there
> > is a problem in the future, we'd prefer the email continues to work so
> > that you are contactable. If you are submitting a small amount of
> > changes it's probably never going to matter. If you are submitting
> > larger bodies of work of course it would be good to have a company or
> > larger org attached to track things down legally later, but again that
> > isn't always possible.
> >
> > I don't think alienating the numerous developers who no longer use
> > their legal names are identified by one name, but haven't changed
> > their legal one yet people who get married and change their legal name
> > but don't change their contribution name and I could run this sentence
> > on forever.
> 
> Yeah like absolute best case trying to "enforce" this just results in
> encouraging people to come up with entirely fake but English looking
> names for themselves. Which ... just no.

Agree, again, I'd prefer to take real names in native languages, our
tools can handle that just fine.  No need to make up anything.

thanks,

greg k-h


More information about the dri-devel mailing list