[PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

Thomas Zimmermann tzimmermann at suse.de
Mon Jun 20 14:43:18 UTC 2022


Hi

Am 20.06.22 um 16:40 schrieb Maxime Ripard:
> On Mon, Jun 20, 2022 at 04:19:43PM +0200, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 20.06.22 um 14:18 schrieb Maxime Ripard:
>>> + * At driver unload time the driver's &drm_connector_funcs.destroy hook
>>> + * should call drm_connector_unregister(), drm_connector_cleanup() and
>>> + * kfree() the connector structure.
>>
>> This sentence sounds odd.
> 
> Yeah, I was using kfree as a verb which is probably where the weirdness comes from.
> 
> Would that be better:
> 
> At driver unload time the driver's &drm_connector_funcs.destroy hook should call
> drm_connector_unregister() and free the connector structure.

Yes. That's better.

Best regards
Thomas

> 
> Maxime

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220620/d6f5af83/attachment-0001.sig>


More information about the dri-devel mailing list