[PATCH v2] drm/i915/gem: add missing else

zys.zljxml at gmail.com zys.zljxml at gmail.com
Mon Jun 20 11:59:53 UTC 2022


From: katrinzhou <katrinzhou at tencent.com>

Add missing else in set_proto_ctx_param() to fix coverity issue.

Addresses-Coverity: ("Unused value")
Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)")
Suggested-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Signed-off-by: katrinzhou <katrinzhou at tencent.com>
---
Update from v1:
Fixed the code logic as suggested by Tvrtko Ursulin.

 drivers/gpu/drm/i915/gem/i915_gem_context.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index ab4c5ab28e4d..1099a383e55a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -933,7 +933,8 @@ static int set_proto_ctx_param(struct drm_i915_file_private *fpriv,
 	case I915_CONTEXT_PARAM_PERSISTENCE:
 		if (args->size)
 			ret = -EINVAL;
-		ret = proto_context_set_persistence(fpriv->dev_priv, pc,
+		else
+			ret = proto_context_set_persistence(fpriv->dev_priv, pc,
 						    args->value);
 		break;
 
-- 
2.27.0



More information about the dri-devel mailing list