[PATCH v3 16/16] drm/tilcdc: Convert to platform remove callback returning void

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Dec 4 17:04:56 UTC 2023


On Tue, Nov 28, 2023 at 07:54:31PM +0000, sarha at kapsi.fi wrote:
> November 28, 2023 at 6:49 PM, "Uwe Kleine-König" <u.kleine-koenig at pengutronix.de mailto:u.kleine-koenig at pengutronix.de?to=%22Uwe%20Kleine-K%C3%B6nig%22%20%3Cu.kleine-koenig%40pengutronix.de%3E > wrote:
> 
> > 
> > On Fri, Nov 03, 2023 at 09:58:07AM +0200, Tomi Valkeinen wrote:
> > 
> > > 
> > > On 02/11/2023 18:56, Uwe Kleine-König wrote:
> > > The .remove() callback for a platform driver returns an int which makes
> > > many driver authors wrongly assume it's possible to do error handling by
> > > returning an error code. However the value returned is (mostly) ignored
> > > and this typically results in resource leaks. To improve here there is a
> > > quest to make the remove callback return void. In the first step of this
> > > quest all drivers are converted to .remove_new() which already returns
> > > void.
> > > [...]
> > > 
> > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
> > > 
> > 
> > This patch didn't make it into next yet. Who is responsible to pick this
> > up?
> > 
> 
> I expected the whole series had been applied at once. But yes, I can apply this patch.

Thanks.

Thomas wrote in
https://lore.kernel.org/dri-devel/250b5d51-93f8-4d8c-8507-0c47adbf7237@suse.de:

	Except for patches 8 and 16, I've pushed this patchset into drm-misc-next.

. I understand he skipped patch 8, but for patch 16 I guess that's just
an oversight.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20231204/30a5074a/attachment.sig>


More information about the dri-devel mailing list