[PATCH 6/7] accel/qaic: Leverage DRM managed APIs to release resources

Jacek Lawrynowicz jacek.lawrynowicz at linux.intel.com
Wed Dec 20 07:02:37 UTC 2023


On 15.12.2023 19:06, Jeffrey Hugo wrote:
> On 12/8/2023 9:34 AM, Jeffrey Hugo wrote:
>> From: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy at quicinc.com>
>>
>> Offload the balancing of init and destroy calls to DRM managed APIs.
>> mutex destroy for ->cntl_mutex is not called during device release and
>> destroy workqueue is not called in error path of create_qdev(). So, use
>> DRM managed APIs to manage the release of resources and avoid such
>> problems.
>>
>> Signed-off-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy at quicinc.com>
>> Reviewed-by: Jeffrey Hugo <quic_jhugo at quicinc.com>
>> Signed-off-by: Jeffrey Hugo <quic_jhugo at quicinc.com>
> 
> Jacek, I saw a review from you for 1-5, and 7 but not this patch (6). Did I miss something?

Sorry, I was out of office for a couple days and I wasn't able to finish the review.

Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz at linux.intel.com>


More information about the dri-devel mailing list