[PATCH 6/7] drm/vmwgfx: Abstract placement selection

[kernel test robot]

Hi Zack,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next-fixes]
[also build test WARNING on linus/master v6.2-rc5]
[cannot apply to drm-misc/drm-misc-next drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip next-20230127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Zack-Rusin/drm-vmwgfx-Use-the-common-gem-mmap-instead-of-the-custom-code/20230128-112136
base:   git://anongit.freedesktop.org/drm-intel for-linux-next-fixes
patch link:    https://lore.kernel.org/r/20230126173813.602748-7-zack%40kde.org
patch subject: [PATCH 6/7] drm/vmwgfx: Abstract placement selection
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20230128/202301282318.DOogLmvQ-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9083af8be713dc1052ca4bd2b39579979345e47b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Zack-Rusin/drm-vmwgfx-Use-the-common-gem-mmap-instead-of-the-custom-code/20230128-112136
        git checkout 9083af8be713dc1052ca4bd2b39579979345e47b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/cxl/ drivers/gpu/drm/vmwgfx/ kernel/entry/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:509:29: warning: variable 'dst_pitch' is uninitialized when used here [-Wuninitialized]
           src_offset = ddirty->top * dst_pitch + ddirty->left * stdu->cpp;
                                      ^~~~~~~~~
   drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:492:26: note: initialize the variable 'dst_pitch' to silence this warning
           s32 src_pitch, dst_pitch;
                                   ^
                                    = 0
   1 warning generated.


vim +/dst_pitch +509 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c

   475	
   476	
   477	/**
   478	 * vmw_stdu_bo_cpu_commit - Callback to do a CPU blit from buffer object
   479	 *
   480	 * @dirty: The closure structure.
   481	 *
   482	 * For the special case when we cannot create a proxy surface in a
   483	 * 2D VM, we have to do a CPU blit ourselves.
   484	 */
   485	static void vmw_stdu_bo_cpu_commit(struct vmw_kms_dirty *dirty)
   486	{
   487		struct vmw_stdu_dirty *ddirty =
   488			container_of(dirty, struct vmw_stdu_dirty, base);
   489		struct vmw_screen_target_display_unit *stdu =
   490			container_of(dirty->unit, typeof(*stdu), base);
   491		s32 width, height;
   492		s32 src_pitch, dst_pitch;
   493		struct ttm_buffer_object *src_bo, *dst_bo;
   494		u32 src_offset, dst_offset;
   495		struct vmw_diff_cpy diff = VMW_CPU_BLIT_DIFF_INITIALIZER(stdu->cpp);
   496	
   497		if (!dirty->num_hits)
   498			return;
   499	
   500		width = ddirty->right - ddirty->left;
   501		height = ddirty->bottom - ddirty->top;
   502	
   503		if (width == 0 || height == 0)
   504			return;
   505	
   506		/* Assume we are blitting from Guest (bo) to Host (display_srf) */
   507		src_pitch = stdu->display_srf->metadata.base_size.width * stdu->cpp;
   508		src_bo = &stdu->display_srf->res.backup->base;
 > 509		src_offset = ddirty->top * dst_pitch + ddirty->left * stdu->cpp;
   510	
   511		dst_pitch = ddirty->pitch;
   512		dst_bo = &ddirty->buf->base;
   513		dst_offset = ddirty->fb_top * src_pitch + ddirty->fb_left * stdu->cpp;
   514	
   515		(void) vmw_bo_cpu_blit(dst_bo, dst_offset, dst_pitch,
   516				       src_bo, src_offset, src_pitch,
   517				       width * stdu->cpp, height, &diff);
   518	}
   519	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests