[PATCH 09/10] drm/tidss: IRQ code cleanup

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Thu Nov 2 07:00:11 UTC 2023


On 01/11/2023 16:52, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Wed, Nov 01, 2023 at 11:17:46AM +0200, Tomi Valkeinen wrote:
>> The IRQ setup code is overly complex. All we really need to do is
>> initialize the related fields in struct tidss_device, and request the
>> IRQ.
>>
>> We can drop all the HW accesses, as they are pointless: the driver will
>> set the IRQs correctly when it needs any of the IRQs, and at probe time
>> we have done a reset, so we know that all the IRQs are masked by default
>> in the hardware.
> 
> Even for K2G ?

Good point. I'll add a simple manual reset for k2g, masking the IRQs and 
disabling the VPs.

  Tomi



More information about the dri-devel mailing list