[PATCH v5 1/4] drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man

[Karolina Stolarek]

On 7.11.2023 10:34, Christian König wrote:
> Am 16.10.23 um 10:52 schrieb Karolina Stolarek:
>> diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c 
>> b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
>> index 81661d8827aa..c605f010ea08 100644
>> --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
>> +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
>> @@ -29,19 +29,42 @@ struct ttm_buffer_object *ttm_bo_kunit_init(struct 
>> kunit *test,
>>                           struct ttm_test_devices *devs,
>>                           size_t size)
>>   {
>> -    struct drm_gem_object gem_obj = { .size = size };
>> +    struct drm_gem_object gem_obj = { };
>>       struct ttm_buffer_object *bo;
>> +    int err;
>>       bo = kunit_kzalloc(test, sizeof(*bo), GFP_KERNEL);
>>       KUNIT_ASSERT_NOT_NULL(test, bo);
>>       bo->base = gem_obj;
>> +    err = drm_gem_object_init(devs->drm, &bo->base, size);
>> +    KUNIT_ASSERT_EQ(test, err, 0);
>> +
>>       bo->bdev = devs->ttm_dev;
>> +    kref_init(&bo->kref);
>>       return bo;
>>   }
>>   EXPORT_SYMBOL_GPL(ttm_bo_kunit_init);
>> +struct ttm_place *ttm_place_kunit_init(struct kunit *test,
>> +                       uint32_t mem_type, uint32_t flags,
>> +                       size_t size)
>> +{
>> +    struct ttm_place *place;
>> +
>> +    place = kunit_kzalloc(test, sizeof(*place), GFP_KERNEL);
>> +    KUNIT_ASSERT_NOT_NULL(test, place);
>> +
>> +    place->mem_type = mem_type;
>> +    place->flags = flags;
>> +    place->fpfn = size >> PAGE_SHIFT;
>> +    place->lpfn = place->fpfn + (size >> PAGE_SHIFT);
> 
> What should that be good for here? Just to test fpfn and lpfn 
> functionality?
> 
> If yes then I think that would be better in the test case and not the 
> helper.

OK, I'll move it to the test. And yes, that was my intention.

> Apart from that looks good of hand.

Thanks for taking a look!

All the best,
Karolina