[PATCH] drm/sched: Define pr_fmt() for DRM using pr_*()

Danilo Krummrich dakr at redhat.com
Fri Nov 10 00:58:30 UTC 2023


On 11/10/23 01:27, Luben Tuikov wrote:
> Define pr_fmt() as "[drm] " for DRM code using pr_*() facilities, especially
> when no devices are available. This makes it easier to browse kernel logs.
> 
> Signed-off-by: Luben Tuikov <ltuikov89 at gmail.com>
> ---
>   include/drm/drm_print.h | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index a93a387f8a1a15..e8fe60d0eb8783 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -26,6 +26,20 @@
>   #ifndef DRM_PRINT_H_
>   #define DRM_PRINT_H_
>   
> +/* Define this before including linux/printk.h, so that the format
> + * string in pr_*() macros is correctly set for DRM. If a file wants
> + * to define this to something else, it should do so before including
> + * this header file.

There are a couple occurrences of pr_fmt in drm code, but it seems like
all of those are correctly defined before any includes.

Acked-by: Danilo Krummrich <dakr at redhat.com>

> + *
> + * It is encouraged code using pr_err() to prefix their format with
> + * the string "*ERROR* ", to make it easier to scan kernel logs. For
> + * instance,
> + *   pr_err("*ERROR* <the rest of your format string here>", args).
> + */
> +#ifndef pr_fmt
> +#define pr_fmt(fmt) "[drm] " fmt
> +#endif
> +
>   #include <linux/compiler.h>
>   #include <linux/printk.h>
>   #include <linux/seq_file.h>
> 
> base-commit: f3123c2590005c5ff631653d31428e40cd10c618



More information about the dri-devel mailing list