[REGRESSION]: acpi/nouveau: Hardware unavailable upon resume or suspend fails

[Hans de Goede]

Hi All,

On 11/10/23 07:09, Kai-Heng Feng wrote:
> Hi Owen,
> 
> On Fri, Nov 10, 2023 at 5:55 AM Owen T. Heisler <writer at owenh.net> wrote:
>>
>> #regzbot introduced: 89c290ea758911e660878e26270e084d862c03b0
>> #regzbot link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/273
>> #regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=218124
> 
> Thanks for the bug report. Do you prefer to continue the discussion
> here, on gitlab or on bugzilla?

Owen, as Kai-Heng said thank you for reporting this.

>> ## Reproducing
>>
>> 1. Boot system to framebuffer console.
>> 2. Run `systemctl suspend`. If undocked without secondary display,
>> suspend fails. If docked with secondary display, suspend succeeds.
>> 3. Resume from suspend if applicable.
>> 4. System is now in a broken state.
> 
> So I guess we need to put those devices to ACPI D3 for suspend. Let's
> discuss this on your preferred platform.

Ok, so I was already sort of afraid we might see something like this
happening because of:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=89c290ea758911e660878e26270e084d862c03b0

As I mentioned during the review of that, it might be better to
not touch the video-card ACPI power-state at all and instead
only do acpi_device_fix_up_power() on the child devices.

Owen, attached are 2 patches which implement only
calling acpi_device_fix_up_power() on the child devices,
can you build a v6.6 kernel with these 2 patches added
on top please and see if that fixes things ?

Kai-Heng can you test that the issue on the HP ZBook Fury 16 G10
is still resolved after applying these patches ?

Regards,

Hans

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ACPI-PM-Add-acpi_device_fix_up_power_children-functi.patch
Type: text/x-patch
Size: 2169 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20231110/fc6d0dc0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ACPI-video-Use-acpi_device_fix_up_power_children.patch
Type: text/x-patch
Size: 1812 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20231110/fc6d0dc0/attachment-0001.bin>