[Intel-gfx] [PATCH v3] drm/i915: Skip pxp init if gt is wedged

Teres Alexis, Alan Previn alan.previn.teres.alexis at intel.com
Mon Nov 13 23:32:19 UTC 2023


On Mon, 2023-11-13 at 14:49 -0800, Zhanjun Dong wrote:
> The gt wedged could be triggered by missing guc firmware file, HW not
> working, etc. Once triggered, it means all gt usage is dead, therefore we
> can't enable pxp under this fatal error condition.
> 
> 
alan:skip
alan: this looks good (as per our offline review/discussion),
we dont mess with the current driver startup sequence (i.e. pxp
failures can never pull down the driver probing and will not
generate warnings or errors). Also, if something does break for PXP,
we only do a drm_debug if the failure returned is not -ENODEV
(since -ENODEV can happen on the majority of cases with
legacy products or with non-PXP kernel configs):

Reviewed-by: Alan Previn <alan.previn.teres.alexis at intel.com>


More information about the dri-devel mailing list