[PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

Michael Walle mwalle at kernel.org
Tue Nov 14 15:53:40 UTC 2023


Hi,

> My current guess would be that the issue I was seeing was already fixed
> with dd9e329af723 ("drm/bridge: ti-sn65dsi83: Fix enable/disable flow 
> to
> meet spec") and I didn't properly test both changes separately.

I had the exact same thought, as I've found your second patch.

> My cheap scope is not able to capture the DSI signals and I admit that
> we didn't use our more expensive equipment to verify the changes back 
> then.
> 
> Instead, we had an automated test setup to do cyclic on/off switching
> for the display and check for a black screen using a sensor. It is 
> quite
> a hassle to set up and I'm currently not planning to spend that much
> effort to verify this change again.

That is actually, what we are also doing right now and how the issue was
found in the first place.

> Anyway, I currently don't see any reasons to not revert my changes. 
> Your
> revert looks correct and seems to work fine as far as I can tell.
> 
> Reviewed-by: Frieder Schrempf <frieder.schrempf at kontron.de>

Thanks!

-michael


More information about the dri-devel mailing list