[PATCH 10/32] auxdisplay/ht16k33: Initialize fb_ops with fbdev macros

Miguel Ojeda miguel.ojeda.sandonis at gmail.com
Tue Nov 21 23:45:29 UTC 2023


On Wed, Nov 15, 2023 at 11:30 AM Thomas Zimmermann <tzimmermann at suse.de> wrote:
>
> Initialize the instance of struct fb_ops with fbdev initializer
> macros for framebuffers in virtual address space. Set the read/write,
> draw and mmap callbacks to the correct implementation and avoid
> implicit defaults. Also select the necessary helpers in Kconfig.
>
> Fbdev drivers sometimes rely on the callbacks being NULL for a
> default I/O-memory-based implementation to be invoked; hence
> requiring the I/O helpers to be built in any case. Setting all
> callbacks in all drivers explicitly will allow to make the I/O
> helpers optional. This benefits systems that do not use these
> functions.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Miguel Ojeda <ojeda at kernel.org>
> Cc: Robin van der Gracht <robin at protonic.nl>

Acked-by: Miguel Ojeda <ojeda at kernel.org>

Cheers,
Miguel


More information about the dri-devel mailing list