[PATCH 2/3] drm/bridge: ti-sn65dsi86: Change parameters of ti_sn65dsi86_{read, write}_u16

Doug Anderson dianders at chromium.org
Wed Nov 29 00:34:30 UTC 2023


Hi,

On Thu, Nov 23, 2023 at 9:54 AM Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:
>
> This aligns the function's parameters to regmap_{read,write} and
> simplifies the next change that takes pwm driver data out of struct
> ti_sn65dsi86.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

I'm on the fence for this one. It almost feels like if this takes a
"regmap" as the first field then it should be part of the regmap API.
Adding a concept like this to the regmap API might be interesting if
there were more than one user, but that's a pretty big yak to shave.

I'd tend to agree with your statement in the cover letter that this
patch really makes more sense if we were to take patch #3, and (as per
my response there) I'm not convinced.

That being said, similar to patch #3 if everything else thinks this is
great then I won't stand in the way.

-Doug


More information about the dri-devel mailing list