[PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify using pm_runtime_resume_and_get()

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Nov 29 09:51:37 UTC 2023


Hello Laurent,

On Wed, Nov 29, 2023 at 02:39:55AM +0200, Laurent Pinchart wrote:
> On Thu, Nov 23, 2023 at 06:54:27PM +0100, Uwe Kleine-König wrote:
> > pm_runtime_resume_and_get() already drops the runtime PM usage counter
> > in the error case. So a call to pm_runtime_put_sync() can be dropped.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> 
> I wonder if checkpatch should warn about usage of pm_runtime_get_sync().

It should not warn in general. There are cases where
pm_runtime_get_sync() is the right function to use. See for example
commit aec488051633 ("crypto: stm32 - Properly handle pm_runtime_get
failing").

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20231129/4a44bf6d/attachment.sig>


More information about the dri-devel mailing list