(subset) [PATCH] drm/imagination: fix off by one in pvr_vm_mips_init() error handling

Maxime Ripard mripard at kernel.org
Thu Nov 30 09:26:23 UTC 2023


On Thu, 30 Nov 2023 10:27:15 +0300, Dan Carpenter wrote:
> If the call to vmap() fails the "page_nr" is one element beyond the end
> of the mips_data->pt_dma_addr[] and mips_data->pt_pages[] arrays.
> 
> The way that this is traditionally written is that we clean up the
> partial loop iteration before the goto and then we can say
> while (--i >= 0).  At that point we know that all the elements thus
> far are initialized so we don't need to have NULL checks.
> 
> [...]

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime



More information about the dri-devel mailing list