[PATCH v2 5/8] drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info

Biju Das biju.das.jz at bp.renesas.com
Mon Oct 16 09:37:57 UTC 2023


Hi Robert Foss,

Thanks for the feedback.

> Subject: Re: [PATCH v2 5/8] drm: adv7511: Add reg_cec_offset variable to
> struct adv7511_chip_info
> 
> On Wed, Aug 30, 2023 at 4:24 PM Biju Das <biju.das.jz at bp.renesas.com>
> wrote:
> >
> > The ADV7533 and ADV7535 have an offset(0x70) for the CEC register map
> > compared to ADV7511. Add the reg_cec_offset variable to struct
> > adv7511_chip_info to handle this difference and drop the
> > reg_cec_offset variable from struct adv7511.
> >
> > This will avoid assigning reg_cec_offset based on chip type and also
> > testing for multiple chip types for calling
> adv7533_patch_cec_registers().
> 
> s/for calling/by calling/ ?

OK. I guess it will be taken care while applying.
Otherwise please let me know if I need to send V3.

Cheers,
Biju

> 
> Reviewed-by: Robert Foss <rfoss at kernel.org>


More information about the dri-devel mailing list