[PATCH 06/11] accel/ivpu: Change test_mode module param to bitmask

Stanislaw Gruszka stanislaw.gruszka at linux.intel.com
Sat Oct 28 08:18:39 UTC 2023


On Fri, Oct 27, 2023 at 08:47:11AM -0600, Jeffrey Hugo wrote:
> On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
> > From: Karol Wachowski <karol.wachowski at linux.intel.com>
> > 
> > Change meaning of test_mode module parameter from integer value
> > to bitmask allowing setting different test features with corresponding
> > bits.
> > 
> > Signed-off-by: Karol Wachowski <karol.wachowski at linux.intel.com>
> > Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>
> > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>
> 
> Seems like this changes the uAPI.  You still haven't made a release of the
> userspace, correct? 

Yes the user space is not yet released. However I think module parameter
is not considered part of the linux kernel uAPI and there are no guaranties
regarding not changing or removing or change the semantics.

Obviously we don't want to brake anyone config file or script, but that's more
like courtesy than hardcoded rule. Currently nobody except Intel and it's
partners are using intel_vpu and all user should be aware of the change.

Regards
Stanislaw


More information about the dri-devel mailing list