[PATCH v2 2/4] drm/v3d: fix up register addresses for V3D 7.x

[Iago Toral]

El lun, 30-10-2023 a las 11:28 +0100, Stefan Wahren escribió:
> Hi Iago,
> 
> Am 30.10.23 um 11:14 schrieb Iago Toral:
> > Hi Stefan,
> > 
> > El lun, 30-10-2023 a las 10:58 +0100, Stefan Wahren escribió:
> > > Hi Iago,
> > > 
> > > Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga:
> > > > This patch updates a number of register addresses that have
> > > > been changed in Raspberry Pi 5 (V3D 7.1) and updates the
> > > > code to use the corresponding registers and addresses based
> > > > on the actual V3D version.
> > > > 
> > > > v2:
> > > >    - added s-o-b and commit message. (Maíra Canal)
> > > >    - Used macro that takes version as argument and returns
> > > >      appropriate values instead of two different definitions
> > > >      for post-v71 and pre-v71 hardware when possible. (Maíra
> > > > Canal)
> > > >    - fixed style warnings from checkpatch.pl. (Maíra Canal)
> > > > 
> > > > Signed-off-by: Iago Toral Quiroga <itoral at igalia.com>
> > > > ---
> > > >    drivers/gpu/drm/v3d/v3d_debugfs.c | 178 +++++++++++++++++---
> > > > -----
> > > > -----
> > > >    drivers/gpu/drm/v3d/v3d_gem.c     |   4 +-
> > > >    drivers/gpu/drm/v3d/v3d_irq.c     |  46 ++++----
> > > >    drivers/gpu/drm/v3d/v3d_regs.h    |  94 +++++++++-------
> > > >    drivers/gpu/drm/v3d/v3d_sched.c   |  38 ++++---
> > > >    5 files changed, 204 insertions(+), 156 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/v3d/v3d_debugfs.c
> > > > b/drivers/gpu/drm/v3d/v3d_debugfs.c
> > > > index 330669f51fa7..f843a50d5dce 100644
> > > > --- a/drivers/gpu/drm/v3d/v3d_debugfs.c
> > > > +++ b/drivers/gpu/drm/v3d/v3d_debugfs.c
> > > > @@ -12,69 +12,83 @@
> > > >    #include "v3d_drv.h"
> > > >    #include "v3d_regs.h"
> > > > 
> > > > -#define REGDEF(reg) { reg, #reg }
> > > > +#define REGDEF(min_ver, max_ver, reg) { min_ver, max_ver, reg,
> > > > #reg }
> > > >    struct v3d_reg_def {
> > > > +       u32 min_ver;
> > > > +       u32 max_ver;
> > > Is this documented some where which SoC has which V3D version?
> > > 
> > Not that I am aware of.
> > 
> > There are really only two Raspberry Pi SoCs supported by v3d:
> > bcm2711
> > is Raspberry Pi 4 which is V3D 4.2 (compatible with 4.1), and
> > bcm2712
> > is Raspberry Pi 5 which is V3D 7.1.
> okay, in this case the best source would be Emma's wiki [1]. Maybe
> these
> should be added as well to the wiki.

Sure, will do that, thanks!

Iago

> 
> [1] -
> https://github.com/anholt/linux/wiki/Devices-with-Videocore-graphics
> > 
> > I don't know what SoCs are supported by versions of V3D before 4.1,
> > I
> > think those were targetting set-top-box hardware that Emma used
> > while
> > setting up the driver before the SoC for Raspberry Pi 4 was
> > available.
> > 
> > Iago
> 
>