[PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Sep 26 10:19:59 UTC 2023


Hi Jani,

Thank you for the patch.

On Thu, Sep 14, 2023 at 04:14:49PM +0300, Jani Nikula wrote:
> Make drm_bridge_get_edid() the one place to call the hook.
> 
> Cc: Andrzej Hajda <andrzej.hajda at intel.com>
> Cc: Neil Armstrong <neil.armstrong at linaro.org>
> Cc: Robert Foss <rfoss at kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart at ideasonboard.com>
> Cc: Jonas Karlman <jonas at kwiboo.se>
> Cc: Jernej Skrabec <jernej.skrabec at gmail.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>

> ---
>  drivers/gpu/drm/drm_bridge_connector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
> index 1da93d5a1f61..31baf1f5ff81 100644
> --- a/drivers/gpu/drm/drm_bridge_connector.c
> +++ b/drivers/gpu/drm/drm_bridge_connector.c
> @@ -238,7 +238,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector,
>  	if (status != connector_status_connected)
>  		goto no_edid;
>  
> -	edid = bridge->funcs->get_edid(bridge, connector);
> +	edid = drm_bridge_get_edid(bridge, connector);
>  	if (!drm_edid_is_valid(edid)) {
>  		kfree(edid);
>  		goto no_edid;

-- 
Regards,

Laurent Pinchart


More information about the dri-devel mailing list