[PATCH 2/3] drm/v3d: update UAPI to match user-space for V3D 7.x

Maira Canal mcanal at igalia.com
Thu Sep 28 15:05:44 UTC 2023


Hi Iago,

On 9/28/23 08:45, Iago Toral Quiroga wrote:
> V3D t.x takes a new parameter to configure TFU jobs that needs

I believe t.x should be 7.x.

> to be provided by user space.

As I mentioned before, please, add your s-o-b.

> ---
>   include/uapi/drm/v3d_drm.h | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h
> index 3dfc0af8756a..1a7d7a689de3 100644
> --- a/include/uapi/drm/v3d_drm.h
> +++ b/include/uapi/drm/v3d_drm.h
> @@ -319,6 +319,11 @@ struct drm_v3d_submit_tfu {
>   
>   	/* Pointer to an array of ioctl extensions*/
>   	__u64 extensions;
> +
> +	struct {
> +		__u32 ioc;
> +		__u32 pad;
> +	} v71;

Is there any possibility that the name of the struct could be more
meaningful?

Best Regards,
- Maíra

>   };
>   
>   /* Submits a compute shader for dispatch.  This job will block on any


More information about the dri-devel mailing list