[PATCH 15/18] HID: picoLCD: Constify lcd_ops

Bruno Prémont bonbons at sysophe.eu
Tue Apr 16 08:07:16 UTC 2024


On Sun, 14 Apr 2024 18:36:13 +0200 Krzysztof Kozlowski wrote:
> 'struct lcd_ops' is not modified by core backlight code, so it can be
> made const for increased code safety.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>

Reviewed-by: Bruno Prémont <bonbons at linux-vserver.org>

> ---
> 
> Depends on the first patch in the series.
> ---
>  drivers/hid/hid-picolcd_lcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-picolcd_lcd.c b/drivers/hid/hid-picolcd_lcd.c
> index 0c4b76de8ae5..061a33ba7b1d 100644
> --- a/drivers/hid/hid-picolcd_lcd.c
> +++ b/drivers/hid/hid-picolcd_lcd.c
> @@ -46,7 +46,7 @@ static int picolcd_check_lcd_fb(struct lcd_device *ldev, struct fb_info *fb)
>  	return fb && fb == picolcd_fbinfo((struct picolcd_data *)lcd_get_data(ldev));
>  }
>  
> -static struct lcd_ops picolcd_lcdops = {
> +static const struct lcd_ops picolcd_lcdops = {
>  	.get_contrast   = picolcd_get_contrast,
>  	.set_contrast   = picolcd_set_contrast,
>  	.check_fb       = picolcd_check_lcd_fb,
> 


More information about the dri-devel mailing list