[PATCH] drm/exynos: Add check for dma_set_max_seg_size

Chen Ni nichen at iscas.ac.cn
Mon Apr 29 02:38:33 UTC 2024


Add check for the return value of dma_set_max_seg_size() and return
the error if it fails in order to catch the error.

Fixes: ddfd4ab6bb08 ("drm/exynos: Fix dma_parms allocation")
Signed-off-by: Chen Ni <nichen at iscas.ac.cn>
---
 drivers/gpu/drm/exynos/exynos_drm_dma.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dma.c b/drivers/gpu/drm/exynos/exynos_drm_dma.c
index e2c7373f20c6..0f942186f3ff 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dma.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dma.c
@@ -51,7 +51,10 @@ static int drm_iommu_attach_device(struct drm_device *drm_dev,
 		return -EINVAL;
 	}
 
-	dma_set_max_seg_size(subdrv_dev, DMA_BIT_MASK(32));
+	ret = dma_set_max_seg_size(subdrv_dev, DMA_BIT_MASK(32));
+	if (ret)
+		return ret;
+
 	if (IS_ENABLED(CONFIG_ARM_DMA_USE_IOMMU)) {
 		/*
 		 * Keep the original DMA mapping of the sub-device and
-- 
2.25.1



More information about the dri-devel mailing list